Hello ron minnich, HAOUAS Elyes, Julius Werner, David Hendricks, Jonathan Neuschäfer, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34075
to look at the new patch set (#6).
Change subject: arch, include, soc: Use common stdint.h ......................................................................
arch, include, soc: Use common stdint.h
There are only minimal differences between the architecture specific stdint.h implementations, so let's tidy them up and merge them together into a single file. In particular,
- Use 'unsigned long' for uintptr_t. This was already the case for x86 and riscv, while arm and mips used 'unsigned int', and arm64 and ppc64 used 'unsigned long long'. This change allows using a single integer type for uintptr_t across all architectures, and brings it into consistency with the rest of the code base, which generally uses 'unsigned long' for memory addresses anyway. This change required fixing several assumptions about integer types in the arm code. - Use _Bool as the boolean type. This is a specialized boolean type that was introduced in C99, and is preferrable over hacking booleans using integers. romcc sadly does not support _Bool, so for that we stick with the old uint8_t. - Drop the least and fast integer types. They aren't used anywhere in the code base and are an unnecessary maintenance burden. Using the standard fixed width types is essentially always better anyway. - Drop the UINT64_C() macro. It also isn't used anywhere and doesn't provide anything that a (uint64_t) cast doesn't. - Implement the rest of the MIN and MAX numerical limits. - Use static assertions to check that the integer widths are correct.
Change-Id: I6b52f37793151041b7bdee9ec3708bfad69617b2 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/arch/arm/armv7/mmu.c D src/arch/arm/include/stdint.h D src/arch/arm64/include/stdint.h D src/arch/mips/include/stdint.h D src/arch/ppc64/include/stdint.h D src/arch/riscv/include/stdint.h D src/arch/x86/include/stdint.h A src/include/stdint.h M src/soc/nvidia/tegra124/lp0/Makefile M src/soc/nvidia/tegra210/lp0/Makefile M src/soc/nvidia/tegra210/mmu_operations.c 11 files changed, 123 insertions(+), 568 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/34075/6