[coreboot-gerrit] Change in ...coreboot[master]: intelblocks/cpu: Add function to enable maximum efficiency

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29771 )

Change subject: intelblocks/cpu: Add function to enable maximum efficiency
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Does Intel call it "maximum efficiency" in their documentation? What
> you describe would lower power not energy, which confuses me. Efficient
> should be to save energy, i.e. the best performance per power.

If you have a look at the MSR description (the big Intel software developer manual), you will find the following text for the bits in question:

Maximum Efficiency Ratio (R/O) 
The is the minimum ratio (maximum efficiency) that the processor 
can operates, in units of 100MHz.

This is the reason for the naming.