Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37514 )
Change subject: soc/intel/skylake: Add option to control microcode inclusion ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@7 PS1, Line 7: microcode … microcode update inclusion
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@10 PS1, Line 10: KabyLake Kaby Lake
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@10 PS1, Line 10: SkyLake Sky Lake
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@10 PS1, Line 10: required to include microcode for all possible SkyLake and KabyLake By default
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@14 PS1, Line 14: By the default By default
https://review.coreboot.org/c/coreboot/+/37514/1//COMMIT_MSG@14 PS1, Line 14: microcode microcode updates
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... PS1, Line 291: HAVE_SKYLAKE_CPU Maybe we can find a better name?
1. `SUPPORTS_SKYLAKE_CPU` 2. `MAINBOARD_SUPPORTS_SKYLAKE_CPU` 3. `MAINBOARD_HAS_SKYLAKE_CPU_SUPPORT`
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... PS1, Line 292: SkyLake Sky Lake
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... PS1, Line 298: KabyLake Kaby Lake
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... PS1, Line 306: KabyLake Ditto.
https://review.coreboot.org/c/coreboot/+/37514/1/src/soc/intel/skylake/Kconf... PS1, Line 310: bool "Board can contain KabyLake QUAD core" Ditto.