Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 21: static const uint32_t get_sku_index(void)
I saw you separate in gpio.h.. It should be fine as well.
Done
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 14: #define SENSOR_DET_360 GPP_C10
remove this, just return 0.
Done
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 41: return gpio_get(SENSOR_DET_360) == 0;
Correct myself, return 1. […]
Done
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 15: #define SENSOR_DET_360 GPP_C10
TBD. Please add TODO here.
Done
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 29: { .id = 3, .name = "sku3" },
Please change to 1,2,3,4. We will separate two different products in model.yaml.
Done