Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47836 )
Change subject: mb/clevo/cml-u: Get rid of gpio.h and use C files instead
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47836/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47836/2//COMMIT_MSG@7
PS2, Line 7: mb/clevo/cml-u: Get rid of gpio.h and use C files instead
also add a note that early gpios are moved to a separate compilation unit and describe the reasons
Done
https://review.coreboot.org/c/coreboot/+/47836/2//COMMIT_MSG@8
PS2, Line 8:
was it tested?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b056e8faac0c426a37501dbc175373c22dde339
Gerrit-Change-Number: 47836
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 22 Nov 2020 16:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment