Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31236 )
Change subject: mb/google/hatch: Configure GPIOs again after FSP-S is done ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Should we push this into cnl/cfl ? There are other boards affected.
Other boards currently have the same work around applied. One reason I did not put this in cnl/cfl common code is because it will have to make a copy of the gpio table or add another callback from SoC to mainboard. But I can look into that since I am not sure when exactly this will be fixed in FSP.
Makes sense. We don't have to make a whole copy. We just need to save the reference and count, but if it's easier to carry the mainboard workaround in a duplicated form we can. Should be marked TODO: this is a hacky workaround that needs to be backed out.
I have added this change to CNL. Let me know what you think: https://review.coreboot.org/c/coreboot/+/31250/