[coreboot-gerrit] New patch to review for coreboot: 68ae65d drivers/intel/gma: Uninitialized var before if condition

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6052

-gerrit

commit 68ae65d62dacd5b7411cec5738e48b7cef15aa4d
Author: Edward O'Callaghan 
Date:   Tue Jun 17 15:04:36 2014 +1000

drivers/intel/gma: Uninitialized var before if condition

The variable 'wait' is used uninitialized whenever 'if' condition is false
                    if (val & DDI_BUF_CTL_ENABLE) {
                        ^~~~~~~~~~~~~~~~~~~~~~~~

Leading to an uninitialized use occurs here:
                    if (wait)
                        ^~~~

Change-Id: I7d96bf1e33b9c4312d4a0ba8276e83d17d6cd070
    Signed-off-by: Edward O'Callaghan 
---
 src/drivers/intel/gma/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c
index 9ddd781..f28e943 100644
--- a/src/drivers/intel/gma/intel_ddi.c
+++ b/src/drivers/intel/gma/intel_ddi.c
@@ -123,7 +123,7 @@ static void intel_wait_ddi_buf_idle(int port)

void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp, int port)
 {
-	int wait;
+	int wait = 0;
    uint32_t val;

if (io_i915_read32(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) {