build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31597 )
Change subject: security/vboot: Add fmap measurements ......................................................................
Patch Set 3:
(12 comments)
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.h File src/security/vboot/vboot_crtm.h:
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.h@49 PS3, Line 49: #if (IS_ENABLED(CONFIG_VBOOT_MEASURED_BOOT) && !ENV_BOOTBLOCK && !ENV_DECOMPRESSOR && !ENV_SMM) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@104 PS3, Line 104: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Read-only VPD") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@108 PS3, Line 108: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Google Binary Blob") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@112 PS3, Line 112: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Intel Flash Descriptor") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@116 PS3, Line 116: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "Intel ME") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@120 PS3, Line 120: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "EC firmware") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@124 PS3, Line 124: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Intel GbE") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@128 PS3, Line 128: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "Platform Data") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@193 PS3, Line 193: for (i = 0; i < sizeof(fmap_runtime_data) / sizeof(fmap_runtime_data[0]); i++) { line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@193 PS3, Line 193: for (i = 0; i < sizeof(fmap_runtime_data) / sizeof(fmap_runtime_data[0]); i++) { Prefer ARRAY_SIZE(fmap_runtime_data)
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@194 PS3, Line 194: if (!strncmp(fmap_runtime_data[i], name, sizeof(fmap_runtime_data[i]))) line over 80 characters
https://review.coreboot.org/#/c/31597/3/src/security/vboot/vboot_crtm.c@195 PS3, Line 195: return tpm_measure_region(rdev, TPM_RUNTIME_DATA_PCR, name); line over 80 characters