Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40531 )
Change subject: mb/google/dedede: Remove pad termination for RAM_STRAP_4
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede...
PS2, Line 26: if (!google_chromeec_get_board_version(&board_ver))
: half_populated = !gpio_get(GPIO_MEM_CH_SEL);
- […]
Fair feedback. Only waddledee and waddledoo will have the strap unstuffed. So no need to penalize other upcoming boards with a call to EC. Added a weak variant specific function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib640211b9f50dfb0174a570eda1625bacbebb855
Gerrit-Change-Number: 40531
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 16:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment