Patrick Georgi (patrick@georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3593
-gerrit
commit 834c531a1d2ab60739890b7f9b3e961fdab2d194 Author: Nico Huber nico.huber@secunet.com Date: Tue Jul 2 16:39:28 2013 +0200
lint: Use temporary build directory
`util/lint/lint-stable-002-build-dir-handling` always overwrites your current `config.h` and `auto.conf` when the pre-commit hook is run. It can be very confusing when your configuration is suddenly broken. So fix it by not using the default build directory.
Change-Id: If2bbc97ac2f12a8203a3769d813386a023f93dd6 Signed-off-by: Nico Huber nico.huber@secunet.com Signed-off-by: Patrick Georgi patrick@georgi-clan.de --- util/lint/lint-stable-002-build-dir-handling | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling index 2dad8a6..1880d30 100755 --- a/util/lint/lint-stable-002-build-dir-handling +++ b/util/lint/lint-stable-002-build-dir-handling @@ -53,9 +53,13 @@ if [ "$MAKE" = "" ]; then fi
# prepare a config to use +TMPOBJ=`mktemp .tmpobj.XXXXXX` +rm $TMPOBJ +TMPOBJ=${TMPOBJ} +mkdir -p ${TMPOBJ} TMPCONFIG=`mktemp .tmpconfig.XXXXXX` rm -f $TMPCONFIG -$MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null +$MAKE obj=$TMPOBJ DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
# look up parent directory CURRENTDIR=`pwd -P` @@ -66,5 +70,5 @@ compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/o compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o" compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
-rm -f $TMPCONFIG +rm -rf $TMPCONFIG $TMPOBJ