Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47310 )
Change subject: mb/google/zork: Add finalize GPIO routine ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47310/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/47310/3/src/mainboard/google/zork/v... PS3, Line 65: need an extra delay here
Why is this delay required?
There was glitch-protection resistor with a value that was too high and kept the signal from going low. I didn't think that information was really needed here because it doesn't really matter to the code, but I can add this to the comment it if you think it's needed. Most of the time we don't really document why hardware changes were required to make changes in the code - that's mostly documented in the bug.