Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38505 )
Change subject: mb/intel/tglrvp: Enable SATA ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38505/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38505/3/src/mainboard/intel/tglrvp/... PS3, Line 47: : register "SataEnable" = "1" do you still need this config as i could see below code, you have relied on .cb on/off options
https://review.coreboot.org/c/coreboot/+/38504/3/src/soc/intel/tigerlake/fsp...