Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38491 )
Change subject: mainboard/hatch: Fix GPE wake comments
......................................................................
Patch Set 3:
(1 comment)
a few review comments aren't handled yet, blocking a merge.
https://review.coreboot.org/c/coreboot/+/38491/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38491/1//COMMIT_MSG@9
PS1, Line 9: The indirection of names is exceedingly confusing
: for ultimately the single interrupt trace of
: EC_PCH_WAKE_ODL between the EC gpio#74 to
: GPD2/LAN_WAKE# on the PCH side.
:
: This helps folks chase this indirection down though
: the code.
Please reflow for 75 characters.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38491
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35d746a202dae06d2f6f1edfaa3889864b09f50d
Gerrit-Change-Number: 38491
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 11:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment