6 Dec
2019
6 Dec
'19
12:28 p.m.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37515 )
Change subject: drivers/intel/fsp2_0: Add logo support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37515/2/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/37515/2/src/drivers/intel/fsp2_0/si... PS2, Line 60: #if (CONFIG(HAVE_FSP_GOP))
there's no need for preprocessor here. […]
Compilation breaks if I do that. The Fsp implementations without "HAVE_FSP_GOP" don't have the members involved in the include files so the code doesn't compile and never gets to the linker stage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaffd2be567861371bbe908c1ef9d7dde483a945
Gerrit-Change-Number: 37515
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Dec 2019 12:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment