Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85152?usp=email )
Change subject: soc/intel/xeon_sp: Skip not pre-routed devices in _PRT reporting ......................................................................
soc/intel/xeon_sp: Skip not pre-routed devices in _PRT reporting
PCI devices not pre-routed will have their interrupt line left as 0. Skip these devices in _PRT reporting.
TESTED=Build and boot on intel/avenuecity CRB
Change-Id: I3d51b75eb0fd1c4ca877f6ac884de2742e7f9630 Signed-off-by: Shuo Liu shuo.liu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85152 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Reviewed-by: yuchi.chen@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/acpi.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Lean Sheng Tan: Looks good to me, approved yuchi.chen@intel.com: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 916e2df..0a4587c 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -225,6 +225,8 @@ uint8_t int_pin = pci_read_config8(dev, PCI_INTERRUPT_PIN); if ((int_pin > PCI_INT_MAX) || (int_pin < PCI_INT_A)) continue; + if (!int_line) + continue;
acpigen_write_PRT_GSI_entry(dev_num, int_pin - PCI_INT_A, int_line);