Attention is currently required from: Angel Pons, Christoph Pomaska. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 14:
(25 comments)
File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig:
https://review.coreboot.org/c/coreboot/+/38920/comment/ae720440_c1ec2d6c PS13, Line 5: select BOARD_ROMSIZE_KB_16384 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select HAVE_OPTION_TABLE : select HAVE_CMOS_DEFAULT : select INTEL_GMA_HAVE_VBT : select INTEL_INT15 : select SOC_INTEL_KABYLAKE : select SKYLAKE_SOC_PCH_H : select MAINBOARD_HAS_LIBGFXINIT : select SUPERIO_ITE_IT8728F # board has actually IT8628E : select MAINBOARD_USES_IFD_GBE_REGION
Reorder alphabetically
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/60f39d8c_e979e449 PS13, Line 17: select FSP_USE_REPO
Remove, since this is enabled by default.
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/31ace47d_62946998 PS13, Line 18:
Add this […]
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/f9c99eca_7eb1d09a PS13, Line 26:
Add this […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38920/comment/c5c7f2ca_22027301 PS13, Line 18: hda_verb.c
Replace with .. […]
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/9f910611_353bff94 PS13, Line 19: gma-mainboard.ads
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/38920/comment/9bde58f3_a4e6a67d PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2014 Google Inc. : * Copyright (C) 2015 Intel Corporation. : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
PS13:
Move this file to variant/ga-z170x-gaming7
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/7ea53e04_0246e8fc PS13, Line 19: register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0"
Remove, because all 0
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38920/comment/824abe6e_e0910530 PS2, Line 34: // CPU
Just the comment or the include aswell?
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38920/comment/4f5da9ff_c732a345 PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2007-2009 coresystems GmbH : * Copyright (C) 2015 Google Inc. : * Copyright (C) 2016 Intel Corporation : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace with .. […]
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/89626536_f5e6b9eb PS13, Line 23: // DSDT revision: ACPI v2.0 and up
Remove
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/e4ec0df5_9e5324b5 PS13, Line 23: 0x02
Replace 0x02 by ACPI_DSDT_REV_2
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/0bda88df_be45564e PS13, Line 34: // CPU
No need for this
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/09a34978_17b52762 PS13, Line 40: /* Image processing unit */ : #include <soc/intel/skylake/acpi/ipu.asl>
Nope
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/507f639f_a8218b68 PS13, Line 46: // Dynamic Platform Thermal Framework : #include "acpi/dptf.asl"
Not needed for now
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
PS13:
Move this file to variant/ga-z170x-gaming7
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.c:
PS13:
Move this file to variant/ga-z170x-gaming7
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/14d4df7d_f4fe0121 PS13, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace with .. […]
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/0f5d8982_1c29ce96 PS13, Line 15: #ifndef CFG_GPIO_H : #define CFG_GPIO_H
No guards necessary here
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/b9fc83e5_6682e26f PS13, Line 265: #endif /* CFG_GPIO_H */
Remove
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
PS13:
Move this file to variant/ga-z170x-gaming7
Done
https://review.coreboot.org/c/coreboot/+/38920/comment/c8c49b8d_5beb2275 PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2019 Christoph Pomaska : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the : * GNU General Public License for more details. : */
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38920/comment/f009283f_d81503da PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2016 Intel Corporation : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
https://review.coreboot.org/c/coreboot/+/38920/comment/60f5ef91_0fbe2f1b PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2016 Intel Corporation. : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace with .. […]
Done