Attention is currently required from: Angel Pons, Christoph Pomaska.
25 comments:
File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig:
select BOARD_ROMSIZE_KB_16384
select HAVE_ACPI_RESUME
select HAVE_ACPI_TABLES
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select INTEL_GMA_HAVE_VBT
select INTEL_INT15
select SOC_INTEL_KABYLAKE
select SKYLAKE_SOC_PCH_H
select MAINBOARD_HAS_LIBGFXINIT
select SUPERIO_ITE_IT8728F # board has actually IT8628E
select MAINBOARD_USES_IFD_GBE_REGION
Reorder alphabetically
Done
Patch Set #13, Line 17: select FSP_USE_REPO
Remove, since this is enabled by default.
Done
Add this […]
Done
Add this […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/Makefile.inc:
Patch Set #13, Line 18: hda_verb.c
Replace with .. […]
Done
Patch Set #13, Line 19: gma-mainboard.ads
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/acpi/dptf.asl:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2014 Google Inc.
* Copyright (C) 2015 Intel Corporation.
* Copyright (C) 2019 Maxim Polyakov <max.senia.poliak@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
Move this file to variant/ga-z170x-gaming7
Done
register "deep_s3_enable_ac" = "0"
register "deep_s3_enable_dc" = "0"
register "deep_s5_enable_ac" = "0"
register "deep_s5_enable_dc" = "0"
Remove, because all 0
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
Patch Set #2, Line 34: // CPU
Just the comment or the include aswell?
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2007-2009 coresystems GmbH
* Copyright (C) 2015 Google Inc.
* Copyright (C) 2016 Intel Corporation
* Copyright (C) 2019 Maxim Polyakov <max.senia.poliak@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
Patch Set #13, Line 23: // DSDT revision: ACPI v2.0 and up
Remove
Done
Replace 0x02 by ACPI_DSDT_REV_2
Done
Patch Set #13, Line 34: // CPU
No need for this
Done
/* Image processing unit */
#include <soc/intel/skylake/acpi/ipu.asl>
Nope
Done
// Dynamic Platform Thermal Framework
#include "acpi/dptf.asl"
Not needed for now
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
Move this file to variant/ga-z170x-gaming7
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.c:
Move this file to variant/ga-z170x-gaming7
Done
/*
* This file is part of the coreboot project.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; version 2 of
* the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
#ifndef CFG_GPIO_H
#define CFG_GPIO_H
No guards necessary here
Done
Patch Set #13, Line 265: #endif /* CFG_GPIO_H */
Remove
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
Move this file to variant/ga-z170x-gaming7
Done
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2019 Christoph Pomaska
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/ramstage.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2016 Intel Corporation
* Copyright (C) 2019 Maxim Polyakov <max.senia.poliak@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2016 Intel Corporation.
* Copyright (C) 2019 Maxim Polyakov <max.senia.poliak@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Replace with .. […]
Done
To view, visit change 38920. To unsubscribe, or for help writing mail filters, visit settings.