Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32318 )
Change subject: nb/intel/nehalem: Hide some raminit output messages
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32318/1/src/northbridge/intel/nehalem/ramini...
File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/32318/1/src/northbridge/intel/nehalem/ramini...
PS1, Line 1569: {
Could also bail out early `if (!CONFIG(DEBUG_RAM_SETUP))`. But maybe that
would require more extensive testing? who knows what removing this code
can cause ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc425f4d10443f6ee7f9b4da67eb6542069cc40c
Gerrit-Change-Number: 32318
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 15:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment