Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40674 )
Change subject: arch/x86/acpi_device: Add a helper function to write PCI device ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c@... PS2, Line 943: struct
const struct ?
This function can be used directly by .acpi_fill_ssdt which unfortunately has a function signature without const for the parameter. I plan to fix that as a wider clean up later on.
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/include/arch/a... PS2, Line 504: PCI device
It is worth mentioning here that if the device is created in the SSDT it can't be accessed from the […]
Good point. I will mention that.