Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39683 )
Change subject: soc/intel/tigerlake: Configure Hyperthreading
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39683/3/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39683/3/src/soc/intel/tigerlake/chi...
PS3, Line 296: HyperThreading
yes. I think it's better use Kconfig file rather than config variable.
I did not mean using a Kconfig. Basically, I meant changing this option to be inverted i.e.
uint8_t HyperThreadingDisable;
I don't think you need a Kconfig for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc94e6b8ecd59a43be60bf60dc7dd0811ac0350b
Gerrit-Change-Number: 39683
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 20 Mar 2020 15:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment