Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27433 )
Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... PS2, Line 181: PAD_CFG_NC(GPP_D8),
However, just keeping GPP_D8 configured here, without the relevant ACPI code configuring the pin cor […]
There's a a fix going into EVT2 firmware that is needed for EVT2 to fix a hang bug, but that same fix will cause preEVT2 units to potentially exhibit the hang bug, which means we will need to obsolete the preEVT2 units once EVT2 units arrive. Given the short-lived nature of preEVT2, I'm ok with this change.