Attention is currently required from: Jakub Czapiga, Julius Werner.
Daniel Gröber (dxld) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42112?usp=email )
Change subject: spi: Add new struct spi_flash_bpbits for block protection bits ......................................................................
Patch Set 26:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/42112/comment/2ca4c236_dad847fa : PS24, Line 7: ove block protection bits to new struct spi_flash_bpbits
This patch does not actually move mentioned values, but only creates new struct for them. […]
Done
File src/include/spi_flash.h:
https://review.coreboot.org/c/coreboot/+/42112/comment/3e904441_85500abe : PS24, Line 53: bp
nit: I think it would be better to use more descriptive field names when possible. […]
The names are taken from the existing code I'm refactoring. See https://review.coreboot.org/c/coreboot/+/42115/26/src/drivers/spi/winbond.c#...
They are based on the winbond datasheet register descriptions, so I think it'd be ill advised to rename them in the code for no good reason.
https://review.coreboot.org/c/coreboot/+/42112/comment/b3fbdb5f_e8645e81 : PS24, Line 56: union {
Is this union necessary?
It's filled with a macronix specific struct later in the series, see https://review.coreboot.org/c/coreboot/+/41750/38/src/include/spi_flash.h