Attention is currently required from: Jakub Czapiga, Julius Werner.
3 comments:
Commit Message:
Patch Set #24, Line 7: ove block protection bits to new struct spi_flash_bpbits
This patch does not actually move mentioned values, but only creates new struct for them. […]
Done
File src/include/spi_flash.h:
nit: I think it would be better to use more descriptive field names when possible. […]
The names are taken from the existing code I'm refactoring. See https://review.coreboot.org/c/coreboot/+/42115/26/src/drivers/spi/winbond.c#b520
They are based on the winbond datasheet register descriptions, so I think it'd be ill advised to rename them in the code for no good reason.
Patch Set #24, Line 56: union {
Is this union necessary?
It's filled with a macronix specific struct later in the series, see https://review.coreboot.org/c/coreboot/+/41750/38/src/include/spi_flash.h
To view, visit change 42112. To unsubscribe, or for help writing mail filters, visit settings.