Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45964 )
Change subject: soc/amd/picasso: Die if the workbuf is missing two boots in a row ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45964/2/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45964/2/src/soc/amd/picasso/bootblo... PS2, Line 142: if (cmos_read(RTC_CLK_ALTCENTURY) != 0xff &&
I agree, but vbnv_cmos_failed is just this one cmos read, which I'm already using in this function, […]
Sure, but that's the point of the function. Just because the picasso implementation is using that method doesn't mean we should expand it anywhere it would be used. We have that wrapper for the consistency of the code base.