Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41387 )
Change subject: mb/google/volteer: Enable TCSS DMA0 and DMA1 for Volteer
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
PS4, Line 140: TcssDma0En
Why is the SoC code not using on/off for 0d.2 to decide whether to set TcssDma0En to 1/0? I think we should update that as a follow-up.
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
PS4, Line 141: TcssDma1En
Same here for 0d.3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05cc9e3964d8037d433fca443be6e8d5b444bbce
Gerrit-Change-Number: 41387
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 21:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment