10 Feb
2020
10 Feb
'20
5:32 a.m.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38753 )
Change subject: mb/facebook/monolith: Use serial number and UUID from VPD ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38753/1/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38753/1/src/mainboard/facebook/mono... PS1, Line 57: else
suggest: Use same handling in smbios_system_serial_number() and smbios_system_set_uuid() […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/38753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b6ce769cfa81a1e248a35f6149b7d1bbcf1f836
Gerrit-Change-Number: 38753
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Feb 2020 08:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment