Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67355 )
Change subject: soc/mediatek/mt8188: enable mfgpll properly and fix SPMI muxes
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67355/comment/c422c9d5_c2a6de7b
PS1, Line 9: We failed to bringup GPU in kernel due to the wrong pll setting.
Some of the pll settings are incorrect, which cause problems in GPU after booting into kernel.
File src/soc/mediatek/mt8188/pll.c:
https://review.coreboot.org/c/coreboot/+/67355/comment/6a9242f5_5cb80c55
PS1, Line 526: setbits32
Use `clrsetbits32`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I971109a5f72e3307899daaf5a5f26022124b559b
Gerrit-Change-Number: 67355
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 06:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment