Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30749
to review the following change.
Change subject: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware ......................................................................
sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware
Currently, by default AGESA's XHCI controller is enabled without XHCI firmware being added if USE_BLOBS isn't selected. With this faulty set of default values at least AMD Lenovo G505S laptop has the following problem: both USB 3.0 ports are not working at all, even at 2.0 mode. To avoid it we should disable XHCI controller by default and allow enabling it only with a firmware provided.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I9f2b88d65f4f300ba1a28db09fb41d6bac6252b6 --- M src/southbridge/amd/agesa/hudson/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30749/1
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig index b80f734..0c6ac3e 100644 --- a/src/southbridge/amd/agesa/hudson/Kconfig +++ b/src/southbridge/amd/agesa/hudson/Kconfig @@ -41,7 +41,8 @@
config HUDSON_XHCI_ENABLE bool "Enable Hudson XHCI Controller" - default y + default n + select HUDSON_XHCI_FWM help The XHCI controller must be enabled and the XHCI firmware must be added in order to have USB 3.0 support configured @@ -50,7 +51,7 @@ XHCI controller is not enabled by coreboot.
config HUDSON_XHCI_FWM - bool "Add xhci firmware" + bool "Add XHCI firmware" default y if USE_BLOBS help Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0