Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41470 )
Change subject: soc/intel/skylake: Mask lower 20 bits of TOLUD and TOLM in systemagent.asl
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41470/1/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/systemagent.asl:
https://review.coreboot.org/c/coreboot/+/41470/1/src/soc/intel/skylake/acpi/...
PS1, Line 194: And (Local0, ShiftLeft(0xfff, 20), Local0)
Why use the old syntax here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ff7a30fabb7f77d13acadec1e6e4cb3a45b6139
Gerrit-Change-Number: 41470
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 16 May 2020 11:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment