Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... PS2, Line 701: int is_usb_speed_ss(usb_speed speed) : { : if (speed == SUPER_SPEED || speed == SUPER_SPEED_PLUS) : return 1; : return 0; : } Sorry to be a pain, but you can use a bool here. and then return (speed == SUPER_SPEED || speed == SUPER_SPEED_PLUS);
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/include... File payloads/libpayload/include/usb/usb.h:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/include... PS2, Line 297: int bool, see above