Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47433 )
Change subject: mb/google/dedede/var/metaknight: Add touchscreen settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47433/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47433/2/src/mainboard/google/dedede...
PS2, Line 59: generic.disable_gpio_export_in_crs" = "1"
Ack
FYI, this is only required for Elan screens. It's because of a quirk in the Elan driver in the kernel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2acd31a8076533c3b927d37127e7d27bac0bb57
Gerrit-Change-Number: 47433
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Chen
tim-chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Nov 2020 19:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Chen
tim-chen@quanta.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment