Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79093?usp=email )
Change subject: nb/intel/sandybridge: Fix unitialized variable issue ......................................................................
nb/intel/sandybridge: Fix unitialized variable issue
commit 1e9601c5ef80 ("nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API") introduced an uninitialized variable issue.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1524317: Uninitialized variables (UNINIT) /src/northbridge/intel/sandybridge/raminit_mrc.c: 332 in spd_fill_pei_data()
Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/79093/1
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index a1805a2..68b02b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -315,7 +315,7 @@ static void spd_fill_pei_data(struct pei_data *pei_data) { struct spd_info spdi = {0}; - unsigned int i, have_memory_down; + unsigned int i, have_memory_down = 0;
mb_get_spd_map(&spdi);