[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN

[Jason Nein (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.

Jason Nein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 )

Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN
......................................................................

Patch Set 7:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/66847/comment/cd24217e_69ed98cd 
PS1, Line 7:
> indent

Done

File src/mainboard/google/skyrim/port_descriptors.c:

https://review.coreboot.org/c/coreboot/+/66847/comment/a98140c0_3c33f94a 
PS1, Line 71: 	{ /* DDI4 - Unused */
> i'm a bit surprised that we don't need the 5th DDI descriptor to be set to unused, since the default […]

Done

File src/vendorcode/amd/fsp/mendocino/platform_descriptors.h:

https://review.coreboot.org/c/coreboot/+/66847/comment/d501309d_c572fd84 
PS1, Line 147: DDI_DP_W_TYPEC
> i think at the time i looked at the reference code those weren't there, but might be that i just loo […]

Yes. I confirmed it's match now

https://review.coreboot.org/c/coreboot/+/66847/comment/11002047_3350e8a6 
PS1, Line 148: DDI_DP_WO_TYPEC
> Can you add a comment to each of them

Done