Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42436 )
Change subject: mb/google/volteer: Override power limits with SKU-specific limits ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42436/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42436/1//COMMIT_MSG@14 PS1, Line 14: 152639350 b:...
https://review.coreboot.org/c/coreboot/+/42436/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42436/1/src/mainboard/google/voltee... PS1, Line 28: override_power_limits i think we need checks here to never increase the limits beyond what is specified in the device tree. the way i think of this is that the device tree specifies the system design limits and the CPU-SKU limits represent the SoC limits. the final limits should be the MIN(a,b).