Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48657 )
Change subject: soc/intel/xeon_sp: Move DMICTL lock ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/48657/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48657/1//COMMIT_MSG@9 PS1, Line 9: FPM FSP
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/cpx/c... PS1, Line 82: pch_lock_dmictl(); Could this be moved to chip_final() instead?
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/pch.c File src/soc/intel/xeon_sp/pch.c:
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/pch.c... PS1, Line 72: uint32_t reg32 = pcr_read32(PID_DMI, PCR_DMI_DMICTL); : pcr_write32(PID_DMI, PCR_DMI_DMICTL, reg32 | PCR_DMI_DMICTL_SRLOCK); pcr_or32 exists, btw