Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38179 )
Change subject: drivers/pc80/rtc: Clean up some inlined functions ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38179/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38179/1//COMMIT_MSG@8 PS1, Line 8:
Could you please document, why you added the checks? […]
Ack
https://review.coreboot.org/c/coreboot/+/38179/2/src/drivers/pc80/rtc/mc1468... File src/drivers/pc80/rtc/mc146818rtc.c:
https://review.coreboot.org/c/coreboot/+/38179/2/src/drivers/pc80/rtc/mc1468... PS2, Line 86: reg_d
Is this variable needed?
Done
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... File src/include/pc80/mc146818rtc.h:
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... PS1, Line 138: if (control_state & RTC_SET)
I have redone this.
Done
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... PS1, Line 155: cmos_enable_rtc();
Right.. But wouldn't the requirement to stop RTC only apply to the RTC register bank of [0.. […]
Ah.. there is AltCentury at 0x32 so let's just keep the disable-logic.