Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39941 )
Change subject: soc/intel/broadwell: add ACPI backlight support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG@11 PS1, Line 11: to match prototypes in i915.h and avoid conflicts.
Well, if it's a clean solution to add to a pile depends on its looks. […]
Ack
https://review.coreboot.org/c/coreboot/+/39941/2/src/soc/intel/broadwell/igd... File src/soc/intel/broadwell/igd.c:
https://review.coreboot.org/c/coreboot/+/39941/2/src/soc/intel/broadwell/igd... PS2, Line 635: gfx
This can't be NULL (unless `chip` is negative). You can read the […]
Done
https://review.coreboot.org/c/coreboot/+/39941/2/src/soc/intel/broadwell/igd... PS2, Line 644: .acpi_fill_ssdt_generator = gma_generate_ssdt,
ouch
Done