Attention is currently required from: Bob Moragues, David Wu, Kane Chen, Tarun Tuli.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75990?usp=email )
Change subject: mb/google/brya: Add support for variant_memcfg_init()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
What exactly will the variant_memcfg_init() do?
Can you instead create a separate mb_cfg for the hynix part and then check the memory type populated in variant_memory_params() and return the mb_cfg for the hynix part that sets CsPiStartHighinEct to 1 in the mb_cfg if / when you determine the DUT is using the hynix part?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4926139e36602f87c8317ab4b476636e02f87771
Gerrit-Change-Number: 75990
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Comment-Date: Thu, 22 Jun 2023 22:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment