Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37703 )
Change subject: asrock/e350m1: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37703/1/src/mainboard/asrock/e350m1... File src/mainboard/asrock/e350m1/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37703/1/src/mainboard/asrock/e350m1... PS1, Line 25: sb_Poweron_Init();
To our current knowledge you can remove this. We call it later in romstage in common code.
Done
https://review.coreboot.org/c/coreboot/+/37703/3/src/mainboard/asrock/e350m1... File src/mainboard/asrock/e350m1/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37703/3/src/mainboard/asrock/e350m1... PS3, Line 19: #include <sb_cimx.h>
unused?
Done