Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34897 )
Change subject: arch/x86: Simplified postcar WB MTRR setup
......................................................................
Patch Set 1:
Patch Set 1:
Would this approach, if applied to all intel platforms, have some issues? Do we need UC holes between cbmem_top() and TSEG?
kindly take a look and read this entire topic https://review.coreboot.org/q/topic:%22dram_cache_wb%22+(status:open%20OR%20...) why we have dropped WB and moved to WP for intermediate caching (cbmem_top -16MB) to cbmem-top
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8822c4dcdced872a19ac183b993e8885aadd0a2c
Gerrit-Change-Number: 34897
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Aug 2019 15:32:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment