Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34801 )
Change subject: chromeec: Depend on events_copy_b to identify the wake source
......................................................................
Patch Set 6:
this change breaks resume from S3 on older ChromeEC platforms which use alt_gp_smi_en (Haswell/Broadwell at least), in the case where there are multiple events in the primary EC event queue on resume.
EG, if device is suspended and then lid closed, on lid open the device will attempt to resume from S3, then immediately return to S3 once the alt_gp_smi_en register is set (in the LPC init code). If the alt_gp_smi_en register is not used (val 0x0000), or this change is partially reverted to still clear the primary event queue, then there is no issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39caae2689e0c2a7bec16416978877885a9afc6c
Gerrit-Change-Number: 34801
Gerrit-PatchSet: 6
Gerrit-Owner: Ravi Chandra Sadineni
ravisadineni@chromium.org
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ravi Chandra Sadineni
ravisadineni@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Todd Broch
tbroch@chromium.org
Gerrit-Comment-Date: Sun, 29 Dec 2019 19:07:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment