hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45399 )
Change subject: soc/mediatek/mt8192: add pmic MT6359P driver ......................................................................
Patch Set 25:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45399/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45399/7//COMMIT_MSG@9 PS7, Line 9: Add pmic MT6359P driver.
Please elaborate. […]
MT6359P is a PMIC chipset for Mediatek MT8192 platform. Reference datasheet: MT6359_PMIC_Data_Sheet_V1.5.docx , RH-D-2018-0205
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... File src/soc/mediatek/mt8192/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... PS24, Line 336: {
Check pmif_arb for these 4 functions. […]
Done
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... PS24, Line 344:
No need for this extra blank line.
Done
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... PS24, Line 374:
Same.
Done
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... PS24, Line 414: (
Remove the parentheses.
Done
https://review.coreboot.org/c/coreboot/+/45399/24/src/soc/mediatek/mt8192/mt... PS24, Line 419: if (pmif_arb == NULL) { : pmif_arb = get_pmif_controller(PMIF_SPI, 0); : if (pmif_arb == NULL) : die("ERROR - Failed to get pmif controller\n"); : }
Can we extract this to a static function init_pmif_arb()?
Done