Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35753 )
Change subject: sb/intel/ibexpeak: Implement PCH function disable in chip_ops
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/pch.c:
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp...
PS7, Line 36: if (pch_type < 0)
: pch_type = pci_read_config8(dev, PCI_DEVICE_ID + 1);
: return pch_type;
Done
It's still there on the latest patchset. What I'm not sure of is what the complexity with the "static int" is for
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d25ffe9af482c77d397a9fdb4f0127e40baddc
Gerrit-Change-Number: 35753
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Oct 2019 09:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment