Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42548 )
Change subject: Add qc_blobs repository
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42548/3/.gitmodules
File .gitmodules:
https://review.coreboot.org/c/coreboot/+/42548/3/.gitmodules@52
PS3, Line 52: update = none
Hmm... […]
Honestly, I don't care what the solution looks like. I just
don't want to accidentally violate licenses.
`git submodule update --checkout` is a perfectly normal command
and people who know it would likely miss it if they are told to
use something else. I think the problem is that the questionable
submodules are initialized in the first place and the easiest way
to prevent that is to not have them in `.gitmodules`. If you
prefer another solution, please go ahead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I247746c1b633343064c9f32ef1556000475d6c4a
Gerrit-Change-Number: 42548
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Assignee: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 29 Dec 2020 01:52:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment