Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34188/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34188/11//COMMIT_MSG@8 PS11, Line 8: Can you please also add details that this CL adds 2 new variant APIs: variant_smi_sleep variant_early_override_gpio_table
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... PS11, Line 22: #include <gpio.h> Not required?
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... PS11, Line 346: UP_20K Why is PU required here when this pad is being actively driven?
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... PS11, Line 110: lte_early_override_table I believe you already confirmed that it is okay to configure the GPIOs this way on non-LTE SKUs?