Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: mediatek/mt8183: Init SPM driver
......................................................................
Patch Set 56:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34545/53/src/soc/mediatek/mt8183/sp...
File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/53/src/soc/mediatek/mt8183/sp...
PS53, Line 277: snprintf(dyna_load_pcm[index].version,
Hi Yu-Ping, […]
"version" removed from struct dyna_load_pcm.
https://review.coreboot.org/c/coreboot/+/34545/53/src/soc/mediatek/mt8183/sp...
PS53, Line 291: printk(BIOS_INFO, "%s done after %ld msecs.\n", __func__,
Could we change all INFO to DEBUG here, and I could remove function name and line as well.
I changed all INFO's to DEBUG's except 2 of them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 56
Gerrit-Owner: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Sep 2019 10:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DAWEI CHIEN
dawei.chien@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
