Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36671 )
Change subject: mb/siemens/mc_apl6: Adjust clock lines used on PCIe-2-PCI bridge
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36671/1/src/mainboard/siemens/mc_ap...
File src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36671/1/src/mainboard/siemens/mc_ap...
PS1, Line 68: pci_write_config8(parent, 0xd8, 0x70);
if only output 4 is enabled, should the value not be 0x0F?
Yes, you are right. Got the wrong register meaning.
Will adjust.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36671
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16f3b6eed0948c8201baecdfbb8052c6c1c335c8
Gerrit-Change-Number: 36671
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Fri, 08 Nov 2019 09:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment