HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42650 )
Change subject: sb/intel/i82801gx: Move `acpi_fill_fadt` to fadt.c ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 54: 0 ACPI_ACCESS_SIZE_UNDEFINED
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 68: 0 ACPI_ACCESS_SIZE_UNDEFINED
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 72: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 79: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 86: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 93: 0 ACPI_ADDRESS_SPACE_MEMORY
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 96: 0 ACPI_ACCESS_SIZE_UNDEFINED