build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: src: Move DEFAULT_MCHBAR to Kconfig ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/gm45/... PS1, Line 238: #define MCHBAR8(x) *((volatile u8 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/gm45/... PS1, Line 239: #define MCHBAR16(x) *((volatile u16 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/gm45/... PS1, Line 240: #define MCHBAR32(x) *((volatile u32 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/pineview.h:
https://review.coreboot.org/c/coreboot/+/45610/1/src/northbridge/intel/pinev... PS1, Line 43: #define MCHBAR32(x) (*((volatile u32 *)(CONFIG_DEFAULT_MCHBAR + x))) /* FIXME: causes changes */ line over 96 characters