Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: [WIP] lib/version: Remove .id section and id.S files ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc@533 PS4, Line 533: idstrings nit: Should this also be called idsection? I'm somewhat confused why there are two different names. (Or maybe we should just call it build_info or something like that?)
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc@534 PS4, Line 534: COREBOOT_VERSION: $(KERNELVERSION) Should put quotes around these just in case.
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/47602/3/src/lib/program.ld@18 PS3, Line 18: #if !(ENV_X86 && ENV_BOOTBLOCK)
If the only actual requirement is for the strings from (now removed) id. […]
I don't think there's really a hard requirement in any way. The practical effect of this used to be that you can see what kind of image it is at the top of the file in a hexdump (because the BOOTBLOCK section is normally the first for Arm platforms). But I don't think it's a big deal, there are plenty of other ways to figure out what an image is, and I'm fine with removing it completely too.